Test your skills: Advanced HTML text — Task 2, paragraph 2: Copy discrepancy
fredhartley opened this issue · comments
MDN URL
What specific section or headline is this issue about?
Task 2
What information was incorrect, unhelpful, or incomplete?
There is a copy discrepancy between the finished examples and the live code in paragraph 2, task 2.
Finished example copy: "HTML, Hypertext Markup Language is by default accessible, if used correctly."
Default live code: "By default, HTML is accessible, if used correctly."
What did you expect to see?
The same copy between the finished example copy and the default life code. I.e. both "HTML, Hypertext Markup Language is by default accessible, if used correctly."
Do you have any supporting links, references, or citations?
No response
Do you have anything more you want to share?
No response
MDN metadata
Page report details
- Folder:
en-us/learn/html/introduction_to_html/test_your_skills_colon__advanced_html_text - MDN URL: https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Test_your_skills:_Advanced_HTML_text
- GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/learn/html/introduction_to_html/test_your_skills_colon__advanced_html_text/index.md
- Last commit: mdn/content@8e2641e
- Document last modified: 2023-02-23T23:55:46.000Z
Hi, there! 👋 I would be happy to pick it and fix this issue.
The same applies to the next line about CSS.
We should also remove "providing expansions as tooltips" from the task description, because the acronyms are written out as recommended and don't need a title attribute.
hello @fredhartley can you please assign this issue to me?
thanks
@advitiya7 Warning — pretty new to GitHub. Maybe you can help. There is no settings cog besides 'Assignees' to assign you. Is this something I can do with my permissions?
As far as I know only maintainers can assign someone. I think it's okay if you just start working on this @advitiya7.
Make sure to mention the issue ID in your PR so they get linked. https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue
Any update on this ?
A month passed since the last update and it seems no one is working on it.
@dostonnabotov and @advitiya7: Is it okay if someone else takes over?
I'm sorry i completely forgot about this i shall do it by 9:30 IST if that is okay with you?
No reason to be sorry. I just wanted to make sure that there aren't two people working on it at the same time.
@mikoMK can you please tell me the location of the html code? the link given above does not have the code
The source of the page is here: https://github.com/mdn/content/blob/main/files/en-us/learn/html/introduction_to_html/test_your_skills_colon__advanced_html_text/index.md. There, you'll find the path to the live sample which is in another repo called "learning-area": https://github.com/mdn/learning-area/tree/main/html/introduction-to-html/tasks/advanced-text.
thanks i wanted the link of learning area
@mikoMK i have made the changes to the repo learning-area please check
Hey @advitiya7 , can you please paste the PR links here ?
Hi @advitiya7 - we've edited in the wrong place, it would be great if you could make changes in the following file:
instead of the "finished" example.
Is this issue still open?
This is now fixed by @letsbecometechie in #654
Thanks, all!