Attributes incorrectly claimed to be added in Chrome 43
foolip opened this issue · comments
Chrome 43 fixed its bindings so that Web IDL attributes appear on the prototypes:
https://developers.google.com/web/updates/2015/04/DOM-attributes-now-on-the-prototype-chain
Because of this, tests like 'attributeName' in InterfaceName can be misleading, suggesting that something was added in Chrome 43. This has come up a lot in @vinyldarkscratch's and my work on https://github.com/foolip/mdn-bcd-collector.
Not all cases of this have been caught in review, and npm run traverse chrome api 43 lists a lot of features. Some of these were introduced earlier, for example api.HTMLMediaElement.volume is much older.
We need to go through any attributes claimed to be added in Chrome 43 and check if they were really available earlier.
#7755 is similar, but for Chrome 44.
While reviewing #7990 I spotted some that I'm almost certain are incorrect and need fixing as part of this issue, namely api.HTMLMediaElement.*. Those are all very old APIs, not introduced in Chrome 43.
@foolip What's the trick to testing that attributes are supported before 43? Testing on actual instances, instead of the prototype?
@ddbeck exactly, an instance is needed, and that's what collector fixes like foolip/mdn-bcd-collector#1247 ends up doing.