Optimization fails for at least one project
mdgriffith opened this issue · comments
Matthew Griffith commented
So, this doesn't seem to be very common, but someone ran into this error when optimizing their project:
Compiled, optimizing JS...
Error: something went wrong, expected number of arguments=1 but got 4 for h0
at Object.exports.matchWrappedInvocation (/opt/homebrew/lib/node_modules/elm-optimize-level-2/dist/transforms/patterns.js:24:31)
at collectFunctions (/opt/homebrew/lib/node_modules/elm-optimize-level-2/dist/transforms/passUnwrappedFunctions.js:19:43)
at visitNode (/opt/homebrew/lib/node_modules/elm-optimize-level-2/node_modules/typescript/lib/typescript.js:74815:23)
at Object.visitEachChild (/opt/homebrew/lib/node_modules/elm-optimize-level-2/node_modules/typescript/lib/typescript.js:75168:46)
at collectFunctions (/opt/homebrew/lib/node_modules/elm-optimize-level-2/dist/transforms/passUnwrappedFunctions.js:58:41)
at visitNodes (/opt/homebrew/lib/node_modules/elm-optimize-level-2/node_modules/typescript/lib/typescript.js:74866:48)
at Object.visitEachChild (/opt/homebrew/lib/node_modules/elm-optimize-level-2/node_modules/typescript/lib/typescript.js:75146:45)
at collectFunctions (/opt/homebrew/lib/node_modules/elm-optimize-level-2/dist/transforms/passUnwrappedFunctions.js:58:41)
at visitNode (/opt/homebrew/lib/node_modules/elm-optimize-level-2/node_modules/typescript/lib/typescript.js:74815:23)
at visitFunctionBody (/opt/homebrew/lib/node_modules/elm-optimize-level-2/node_modules/typescript/lib/typescript.js:74971:23)
So, something to do with tracking function arity somewhere.
I wonder how hard it would be to make it so that any given transformer will just report file coordinates, or even a file snippet when an error is encountered 🤔
Dillon Kearns commented
For visibility, #90 is also related.