mdempsky / gocode

An autocompletion daemon for the Go programming language

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

suggest: test.0011 fails with Go 1.11

mdempsky opened this issue · comments

Go 1.11 added a new MapRange method to reflect.Value, which causes the expectations to fail.

Unfortunately we can't just add this to the expectations because that would cause the test to fail on earlier Go releases, which we still want to maintain compatibility with. Maybe we can add support for version-specific expected outputs.

Looking at the commit where this test case was added (ddfc180), it seems the intent was to check something related to reflect.Value's embedding of the reflect.flag type. Maybe there's another type that can test the same criteria.

Fixed temporarily with 32181df.