tabspaces-switch-or-create not creating new 'workspaces''
appleinario opened this issue · comments
I hope I'm not mistaken here but:
Testing out tabspaces-switch-or-create-workspace doesn't seem to create any new 'workspaces'. I took a look at tabspaces.el, and it is aliased to tab-bar-switch-to-tab. Using that function doesn't create new tabs too, and instead just tries to switch tabs despite no tabs existing.
However, I do see a separate function tab-bar-new-tab / tab-bar-new-tab-to, which creates new tabs. Using the tabspaces-switch-or-create-workspace / tab-bar-switch-to-tab functions switches between the created new tabs.
Am I missing something here? Is the function supposed to work for both switch and creation of 'workspaces'? Thank you so much.
Thanks for this -- you're not missing something. This looks like a regression. I'll have it fixed in a bit.
Ah, this was why when I tested #18 I had weird behavior.
I didn't say anything because I was afraid it was user error.
When NixOS updates or I update packages I'll test it again.
Hi, I also cannot switch, and get the following message:
tabspaces-switch-or-create-workspace: Symbol’s function definition is void: tab-switch
When I export tab-switch in my use-package block by adding it to :commands, the error changes to:
tabspaces-switch-or-create-workspace: Autoloading file .../straight/build/tabspaces/tabspaces.elc failed to define function tab-switch
Hope this helps triangulate the issue!
- Other info: I'm on emacs 27.1 on a Debian 11 box.
- I am the developer of Emacs Groundup, and want to move the distro to project.el and tab-bar for v0.2 - tabspaces has been a fantastic find ! I love the intuitive and simple interface. Thank you for sharing your work with the community 👏
tabspaces-switch-or-create-workspace: Symbol’s function definition is void: tab-switch
tab-switch is an alias in tab-bar.el, which is required by tabspaces. So there is probably a problem with the way tab-bar is being loaded in your config. Maybe try reproducing with emacs -q? If you continue to see the error please open a new issue, as the problem being described in this current issue has been resolved.
* Other info: I'm on emacs 27.1 on a Debian 11 box.
I wonder if the version of tab-bar in emacs 27 doesn't have the alias defined (I'm on emacs 29). Do you see the following in tab-bar.el?
(defalias 'tab-switch 'tab-bar-switch-to-tab)* I am the developer of Emacs Groundup, and want to move the distro to project.el and tab-bar for v0.2 - tabspaces has been a fantastic find ! I love the intuitive and simple interface. Thank you for sharing your work with the community 👏
I'm very glad you've found it useful!
Hi, thank you very much for such an informative response!
I could not find (defalias 'tab-switch 'tab-bar-switch-to-tab) in tab-bar.el.gz ! Does that mean the functionality will not work in emacs 27 ?
Hmm -- is tab-bar-switch-to-tab defined? If so then just create the alias as above and load that before you load tabspaces.el and hopefully things should work. If tab-bar-switch-to-tab isn't present then I'll have to look more closely at the older version of tab-bar.el.
That did the trick! The function was indeed defined, and only the alias was missing. Thank you!!
Great! Let me know if you run into further issues.