EpicEditor missing image file in github skin
opened this issue · comments
The epiceditor/themes/preview/github.css skin points to epiceditor/images/modules/pulls/dirty-shade.png which doesn't exist. This in turn causes django-pipeline to error when running collectstatic.
If epiceditor is pulled from a CDN like it says in the docs, is it really necessary to include its source and assets in your package?
Alternatively, include the missing image file I guess! 👍
Yes, it doesnt really serve from a cdn, but It's served locally from the app's static.
I'll add the image and fix the docs.
Good catch, thank you.
Marco Bonetti
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Saturday, 11 January 2014 at 13:34, twined wrote:
The epiceditor/themes/preview/github.css skin points to epiceditor/images/modules/pulls/dirty-shade.png which doesn't exist. This in turn causes django-pipeline to error when running collectstatic.
If epiceditor is pulled from a CDN like it says in the docs, is it really necessary to include its source and assets in your package?
Alternatively, include the missing image file I guess!—
Reply to this email directly or view it on GitHub (#5).
Awesome - thanks for a great app btw!
Alright, fixed in 1446e3d and 0.3.4. Thanks!
Thanks! There's one more file missing I found:
wym/wymeditor_icon.png
Didn't catch it last time, sorry.
When I touch wym/wymeditor_icon.png in my /static/ dir pipeline parses everything just fine, so that's the last one missing!
Ah, thanks. Pushed 0.3.5 with the missing file.