Giters

mbasso / awesome-wasm

😎 Curated list of awesome things regarding WebAssembly (wasm) ecosystem.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Travis build broken by SSL certificate of one of sites

vkradio opened this issue · comments

commented

General Information

  • Bug
  • Improvement
  • Other

Description

While creating PR #58 there was a failure in Travis build, it complains to SSL certificate of one of the sites in overall list, pls see #58 (comment)

commented

Hi @vkradio,
thank you for opening this issue.
I think that we can fix the build in 2 ways:

  • replace https with http for that resource
  • add the --allow-ssl option to the awesome_bot config to ignore that error
    What do you think?
commented

I've tried to replace https to http, that game will not run. So I think we can suppress error for that string if it is possible.

commented

I've tried http://funkykarts.rocks/demo.html and it works fine for me, can you please check it?
I'm not sure, but I think that we can suppress the error with the --white-list option

commented

I've tried this version (http without www), and checked it with Fiddler. It shows that:

  1. http / -> redirects (301) to http /fLMYb/demo.html
  2. http /fLMYb/demo.html -> redirects (301) to http /demo.html
  3. http /demo.html -> redirects (302) to https https://www.funkykarts.rocks/demo.html
    and so thats it.

So if bot is able to traverse all this path, it may be ok.
Oh no, just realized that after step 3 bot will throw the same error. Let me think...

commented

Or may be bot will be satisfied with just step 1 and then stop as happy?

commented

I think that the bot will be satisfied with just step 1 as you said, but I haven't found enough documentation to make me sure. We can just try this solution.
If it doesn't work, we have to use the --white-list option

commented

Just fixed replacing https with http, thank you very much for contributing 🎉