Switch to streams2
domenic opened this issue · comments
I think this module would be a great example of streams2 code. It'd be pretty simple and would give a few minor benefits like correct backpressure and 'finish' events. I'd assume we'd release this as version 2.0 to avoid breaking any consumers of 1.0.
I'd be happy to do the work for this in a pull request if you're up for it. Just wanted to make sure. Otherwise I'll probably give it a shot myself and release concat-stream-2@1.0.0, which is kind of a sucky name compared to concat-stream@2.0.0 :P.
+1 for concat-stream@2.0.0
I needed a streams2 version a while ago so I added a concat export to terminus -- it is not a port of this, but a work-alike for the stream concatentation this library provies.
It is different, though-- terminus.concat does not take arrays or raw buffers like this library does, and was written to be a generic stream.Writable tool, so I didn't feel it was a candidate for concat-stream@2.0.0
There is also a pretty decent benefit to this library being streams1: you don't need to specify objectMode which for generic and beginner use is quite handy. I'm actually in favor of keeping this library as is.
For those following along at home, relevant commits: #16