Question about utils/evaluation.py

Question

Question about utils/evaluation.py

lawlict opened this issue 5 years ago · comments

Hello @seungwonpark , thank you greatly for your work!
I notice that the utils/evalluation.py has a "break" in the loop of test dataloader.
That is, in the evaluation process, only the first case generated from test dataloader is taken account into computing test loss and test SDR. Could this raise problems like #5 and #9 ?

Look forward to your response.

Seung-won Park · Answer 1 · Tue Aug 27 2019 12:57:45 GMT+0800 (China Standard Time)

Hi, @lawlict

Yes, our current SDR calculation process may cause SDR value to look strange since it evaluates only once.

aurae · Answer 2 · Thu Nov 19 2020 11:01:30 GMT+0800 (China Standard Time)

@lawlict from dataloader.py you can get the batchsize of testloader have only 1, so evalluation.py has a "break" may be ok