mattn / goreman

foreman clone written in go language

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The lattest commit (e06e615661116559a2e76ede8f8c48244c066767) seems to be broken

koshoi opened this issue · comments

Overall

The latest building commit seems to be this one: eefab48

The problem

I was trying to go get github.com/mattn/goreman and got an error:

$ go get github.com/mattn/goreman 
# github.com/mattn/goreman
.go/src/github.com/mattn/goreman/log.go:20: undefined: net.Buffers

But if I try to do this:

$ go get github.com/mattn/goreman
# github.com/mattn/goreman
.go/src/github.com/mattn/goreman/log.go:20: undefined: net.Buffers
$ cd $GOPATH/src/github.com/mattn/goreman
$ git checkout eefab48836ce47f43c6614c008a8e08063a3d398
$ go build github.com/mattn/goreman

Everything works fine.

I believe there are either some missing dependencies or incorrect installment, but seems like eefab48 is the last commit that corresponds with the Getting Started section in README.md

Unfortunetely I am not a strong Go developer but I suppose it is either e06e615661116559a2e76ede8f8c48244c066767to be reverted and reworked or Getting Started section to be updated with the most recent installation instructions.

My OS, Go etc...

$ cat /etc/*-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.4 LTS"
NAME="Ubuntu"
VERSION="16.04.4 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.4 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial
$ go version
go version go1.6.2 linux/amd64
commented

Go 1.6 is too older.

Thank you, everything builds OK when using Go 1.9.

I suppose, you should specify valid Go version in README.md for future users.