Extending native JavaScript objects is a bad practice

Question

Extending native JavaScript objects is a bad practice

mauteri opened this issue 9 years ago · comments

I noticed in a few spots that JavaScript's native Array and String objects are being extended by Liquid with clear, first, last, etc.

With Liquid on our site, we ran into some pretty nasty bugs due to this and had to roll code back. Is there a reason this needs to be done as a property rather than creating helpers for this functionality? I'd be happy to provide a pull request to change this bit of code.

Mike Auteri · Answer 1 · Tue Dec 22 2015 02:58:51 GMT+0800 (China Standard Time)

Added pull request that just sets enumerable to false to prevent Liquid properties from showing up in for...in loops.

Max Frigge · Answer 2 · Fri Feb 10 2017 19:55:32 GMT+0800 (China Standard Time)

I hit this issue too... would be an easy merge. May I ask why this has not been accepted?

Max Frigge · Answer 3 · Fri Feb 10 2017 20:09:27 GMT+0800 (China Standard Time)

Ok.. so it seems to be fixed in master. Are there any known issues in master?

h0jeZvgoxFepBQ2C · Answer 4 · Mon Feb 26 2018 18:37:21 GMT+0800 (China Standard Time)

Yeah, whats the status of this issue?

Mike Auteri · Answer 5 · Mon Feb 26 2018 22:40:06 GMT+0800 (China Standard Time)

Project looks pretty much abandoned to me... Last commit was December 5, 2016... :-/