miracle-window-manager / miracle-wm

Miracle is a Wayland tiling window manager built on Mir

Home Page:https://miracle-wm.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build Instructions fail as written on Archlinux

dleinker opened this issue · comments

cmake -Bbuild fails with 'miral' package not found error on Archlinux.

dan delpad:~/projects/miracle-wm [3046]% cmake -Bbuild
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /sbin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /sbin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /sbin/pkg-config (found version "2.1.0") 
-- Checking for module 'miral'
--   Package 'miral', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:619 (message):
  The following required packages were not found:

   - miral

Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPkgConfig.cmake:841 (_pkg_check_modules_internal)
  CMakeLists.txt:18 (pkg_check_modules)

-- Configuring incomplete, errors occurred!

I see platform requirements are already being discussed. #30

Hi @dleinker 👋 Does installing this package make it build: https://aur.archlinux.org/mir.git?

No, it fails attempting to install wlcs https://aur.archlinux.org/packages/wlcs

[ 99%] Building CXX object CMakeFiles/wlcs.ubsan.dir/tests/text_input_v3_with_input_method_v2.cpp.o
[ 99%] Linking CXX executable wlcs.asan
[ 99%] Building CXX object CMakeFiles/wlcs.ubsan.dir/tests/wlr_virtual_pointer_v1.cpp.o
[100%] Linking CXX executable wlcs.ubsan
[100%] Built target wlcs
[100%] Built target wlcs.tsan
[100%] Built target wlcs.asan
In member function ‘_M_construct’,
    inlined from ‘operator=’ at /usr/include/c++/13.2.1/experimental/optional:346:26,
    inlined from ‘operator=’ at /usr/include/c++/13.2.1/experimental/optional:426:11,
    inlined from ‘operator=’ at /usr/src/debug/wlcs/wlcs-1.5.0/include/in_process_server.h:215:8,
    inlined from ‘done_thunk’ at /usr/src/debug/wlcs/wlcs-1.5.0/src/in_process_server.cpp:1127:57:
/usr/include/c++/13.2.1/experimental/optional:373:11: error: ‘MEM[(struct pair &)&D.13215 + 8]’ may be used uninitialized [-Werror=maybe-uninitialized]
  373 |           ::new (std::__addressof(this->_M_payload))
      |           ^
/usr/src/debug/wlcs/wlcs-1.5.0/src/in_process_server.cpp: In function ‘done_thunk’:
/usr/src/debug/wlcs/wlcs-1.5.0/src/in_process_server.cpp:1127:57: note: ‘<anonymous>’ declared here
lto1: all warnings being treated as errors
make[3]: *** [/tmp/ccDx8SJ0.mk:5: /tmp/cclLkU0j.ltrans1.ltrans.o] Error 1
make[3]: *** Waiting for unfinished jobs....
lto-wrapper: fatal error: make returned 2 exit status
compilation terminated.
/sbin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/wlcs.ubsan.dir/build.make:1035: wlcs.ubsan] Error 1
make[1]: *** [CMakeFiles/Makefile2:223: CMakeFiles/wlcs.ubsan.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'wlcs-1.5.0-1': 
error: packages failed to build: wlcs-1.5.0-1

Supressing warnings in the PKGBUILD for wlcs gets it to install. Installing for the mir aur fails when compiling.

[ 63%] Building CXX object examples/mir_demo_server/CMakeFiles/mir_demo_server.dir/glog_logger.cpp.o
In file included from /home/dan/.cache/paru/clone/mir/src/mir-2.16.3/examples/mir_demo_server/glog_logger.cpp:19:
/usr/include/glog/logging.h:60:4: error: #error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
   60 | #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
      |    ^~~~~

Supressing warnings in the PKGBUILD for wlcs gets it to install. Installing for the mir aur fails when compiling.

[ 63%] Building CXX object examples/mir_demo_server/CMakeFiles/mir_demo_server.dir/glog_logger.cpp.o
In file included from /home/dan/.cache/paru/clone/mir/src/mir-2.16.3/examples/mir_demo_server/glog_logger.cpp:19:
/usr/include/glog/logging.h:60:4: error: #error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
   60 | #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
      |    ^~~~~

This looks to me like the arch build has been neglected for some time now. Good catch since we don't use it too often. I'll try to check out the fix some time this week, but feel free to give it a try beforehand if you like

Probably not the most common setup :) I commented on the relevant aur packages...

@dleinker Sounds good! Should I close this then? Or is there more to investigate here? The author of the mir AUR package hasn't gotten back to me yet