matthuszagh / pyems

High-level python interface to OpenEMS with automatic mesh generation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Be able to return complex values from s_param function in Simulation Class

laberge1 opened this issue · comments

Today, only magnitude can be read out of the s_param function within the Simulation Class, despite setting the "dB" input bool to False. I am sure there are ways around this, but it seems limiting to not allow phase information to be passed out. I propose that by setting the "dB" input to "False" should return the complex value, versus the magnitude/absolute value. This is important for building your own touchstone file (which would also be a nice function to have, but easy enough to build using scikit-rf).

Closing this in favor of your PR. I reverted my merge for that because of the commit message. But once you change the commit message please recreate the PR and I'll merge it.

Opened a PR with a helpful commit message.