Upgrade phpunit/php-code-coverage to 9.0

Question

Upgrade phpunit/php-code-coverage to 9.0

nreynis opened this issue 4 years ago · comments

This package dependencies prevent upgrading to phpunit 9.3.
Being stuck with phpunit 9.2 is an issue because it also lock us away from PHP8.

Nicolas Reynis commented 4 years ago

Done!

Matthias Noback · Answer 1 · Fri Sep 25 2020 14:43:13 GMT+0800 (China Standard Time)

Makes sense, can you make a PR?

Nicolas Reynis · Answer 2 · Sat Sep 26 2020 00:25:58 GMT+0800 (China Standard Time)

I tried to give it a shot, but there's major BC in php-code-coverage.
I'm not familiar with previous version, so I'll have to understand what each method was doing and how it maps to the new API. If I have some time I'll try to dig further, but I can't promise anything.

Matthias Noback · Answer 3 · Mon Sep 28 2020 01:44:44 GMT+0800 (China Standard Time)

Fixed by #16.

Matthias Noback · Answer 4 · Mon Sep 28 2020 01:45:37 GMT+0800 (China Standard Time)

Thanks a lot Nicolas! I've added one other commit because I noticed that PHPUnit now has a FilterMapper that does the work of processing the files and directories etc. inside the config. So that saves us a few lines here.

Matthias Noback · Answer 5 · Mon Sep 28 2020 01:48:05 GMT+0800 (China Standard Time)

By the way, I've released this as v1.4.0.