matthias-research / pages

My web page containing all the demos from my youtube channel "Ten Minute Physics" www.youtube.com/c/TenMinutePhysics

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Name changes and 404 in Three.js

bambax opened this issue · comments

The demos that rely on Three.js don't work because

  • some ressources generate a 404 Not Found error (https://threejs.org/examples/js/controls/OrbitControls.js) which result in errors like Uncaught TypeError: THREE.OrbitControls is not a constructor
  • some classes and function have changed names (THREE.PlaneBufferGeometry has been renamed to THREE.PlaneGeometry.)

Maybe this can be solved easily by adding the correct version of Three.js in the repository instead of hot loading it from threejs.org.

Updated the imports and made a pull request (#17).

Tested to work on a local web server.

Fixed for all TenMinutePhysics demos by #18. Hopefully it will get merged shortly. Cheers!