isUrl module breaks nesting

Question

evilive3000 opened this issue 6 years ago · comments

because of this issue nested selections does not work.

James C. (Jamie) Davis · Answer 1 · Sat Mar 24 2018 12:58:44 GMT+0800 (China Standard Time)

I just opened a PR on that issue.

James C. (Jamie) Davis · Answer 2 · Tue Mar 27 2018 01:07:57 GMT+0800 (China Standard Time)

New version should be available today or tomorrow, monitor this PR.

Wilhelm R. · Answer 3 · Tue Mar 27 2018 02:05:31 GMT+0800 (China Standard Time)

Having a similar problem. is-url version 1.2.3 causes some problems with html as input:

x(html, '.s-result-item.celwidget', ...

Error:

TypeError: string.match is not a function
    at isUrl (...node_modules/is-url/index.js:27:22)

With is-url version 1.2.2 there are no problems.

James C. (Jamie) Davis · Answer 4 · Tue Mar 27 2018 04:01:32 GMT+0800 (China Standard Time)

Please try with is-url version 1.2.4, just published to npm. If you have any issues, open one against the is-url project.

Wilhelm R. · Answer 5 · Tue Mar 27 2018 13:59:11 GMT+0800 (China Standard Time)

thanks @davisjam! updating to version 1.2.4 resolved the issue.