x promise then method not working

Question

x promise then method not working

edjroz opened this issue 7 years ago · comments

Eduardo Díaz commented 7 years ago

Subject of the issue

Promise support not working ?

Your environment

version of node: 8.9.1
version of npm: 5.5.1

Steps to reproduce

const Xray = require('x-ray');                                                                                  
                                                                                                                
const x = Xray();                                                                                               
                                                                                                                
x('https://blog.ycombinator.com', '.post', [{                                                                   
  title: 'h1 a',                                                                                                
  link: '.article-title@href'                                                                                   
}]).then(res => console.log(res));

Expected behaviour

Should console log the array of news

Actual behaviour

TypeError: x(...).then is not a function

willis plummer · Answer 1 · Thu Nov 16 2017 02:38:35 GMT+0800 (China Standard Time)

I'm getting the same result

Nameless God · Answer 2 · Fri Nov 24 2017 14:28:37 GMT+0800 (China Standard Time)

me, too :(

Deleted user · Answer 3 · Wed Nov 29 2017 10:39:04 GMT+0800 (China Standard Time)

same problem !

Dan Cowell · Answer 4 · Fri Dec 01 2017 11:24:14 GMT+0800 (China Standard Time)

Looks like this might be related to #277.

Can you try installing with the repo clone URI? That might be a workaround.

asaldivar · Answer 5 · Mon Dec 04 2017 00:47:00 GMT+0800 (China Standard Time)

@dfcowell Installing with the repo clone URI worked for me.

Sarhan Aissi · Answer 6 · Sun Mar 04 2018 05:09:43 GMT+0800 (China Standard Time)

Any update?

Richard Birkby · Answer 7 · Fri Apr 27 2018 06:08:58 GMT+0800 (China Standard Time)

v2.3.2 (the current latest version on npmjs.org) was taken from a branch prior to Promise support being added. Promise support was committed to the tree prior to the 2.3.2 release, but the commits were not included in that release.

charles bourasseau · Answer 8 · Fri Jun 22 2018 12:56:36 GMT+0800 (China Standard Time)

Would it be possible to release a new version? So that the last version include promises.

Matt Mueller · Answer 9 · Fri Jun 22 2018 23:38:54 GMT+0800 (China Standard Time)

sorry for the delay on this folks, just pushed 2.3.3!

charles bourasseau · Answer 10 · Thu Jun 28 2018 04:46:28 GMT+0800 (China Standard Time)

Thanks.

Issue can be closed.

Eduardo Díaz · Answer 11 · Mon Jul 02 2018 22:52:27 GMT+0800 (China Standard Time)

It seems to be working. Thanks 😄