Release 1.3.2 - wrong dir name in CMakeLists

Question

Release 1.3.2 - wrong dir name in CMakeLists

rspielmann opened this issue 5 years ago · comments

In order to build Release 1.3.2 (https://github.com/mattgodbolt/seasocks/tree/v1.3.2) I had to apply the patch [1] attached to this issue in order to make the build work completely.

If this hasn't been fixed in newer versions, maybe it would make sense to do so :)

[1] 001-seasocks-src-app-c-CMakeLists.txt.patch.txt

offa · Answer 1 · Mon Apr 15 2019 23:35:12 GMT+0800 (China Standard Time)

This has been fixed last year: a51be5d

Please update to a more recent version, v1.4.1 includes the fix. If you have some more minutes; I'm going to create a new release in a few minutes.

Update: v1.4.2 is available.

Robert Spielmann · Answer 2 · Fri Apr 19 2019 03:17:55 GMT+0800 (China Standard Time)

Thanks @offa for the feedback, shortly after creating the issue I did in fact realize that the problem had been resolved. I picked release 1.3.2 because I'm stuck with C++11 for now, and decided to patch the broken line in CMakeLists.txt myself locally. Great library, thanks for providing it :)