Pasting into window in active display
karlhorky opened this issue · comments
Hey @mattDavo ! 👋 Hope that 2022 is treating you well so far!
Yippy continues to be amazing for everything, have recommended it to a bunch of students too! 🙌 They are getting a lot out of it too.
One thing that breaks my workflow often is the multi-monitor support:
When pasting from Yippy, it does not paste to the active app on the last-focused display, it always pastes to the window in the primary monitor (at least, this is the behavior on my MacBook Pro with built-in monitor, when connected to an external display.
Repro steps:
- Connect MacBook to external display
- Use an app such as Google Chrome or iTerm2 with multiple windows - one on the primary monitor, one on the non-primary monitor
- Copy something
- Focus the window in the non-primary display
- Paste from Yippy using the keyboard shortcut
- 💥 The text is pasted in the primary display
@mattDavo I think a workaround for this would be an option to disable the search bar. Do you think this would be possible?
@mattDavo Digging into this a bit today (no idea what I'm doing here with Swift 😅) I found that fixing this properly (focusing the correct window of the NSWorkspace.shared.frontmostApplication to paste into) may be possible by using this AXUIElement thing that I found in the mado-size repo:
static func frontmost() -> AppWindow? {
guard let frontmostApplication = NSWorkspace.shared().frontmostApplication else {
return nil
}
let appElement = AXUIElementCreateApplication(frontmostApplication.processIdentifier)
var result: AnyObject?
guard AXUIElementCopyAttributeValue(appElement, kAXFocusedWindowAttribute as CFString, &result) == .success else {
return nil
}
let windowElement = result as! AXUIElement
return AppWindow(app: frontmostApplication, appElement: appElement, windowElement: windowElement)
}This kAXMainWindowAttribute could then be set using this:
AXUIElementSetAttributeValue(window, kAXMainWindowAttribute as CFString, true as CFTypeRef)Currently, in the YippyViewController.paste method, there is no focus management:
Yippy/Yippy/Sources/Windows/Yippy/YippyViewController.swift
Lines 298 to 302 in c9fb7ea
However, there is some focus management in the YippyWindowController - maybe the active window AXUIElement could be saved there?
Yippy/Yippy/Sources/Windows/Yippy/YippyViewController.swift
Lines 298 to 302 in c9fb7ea
What do you think?
Haha btw ChatGPT agrees here (of course, this could always be wrong, haven't looked in detail yet):
Full answer:
To restore focus to the main window of the frontmost application using NSWorkspace, AXUIElementCreateApplication and AXUIElement in Swift, you can try the following steps:
Use NSWorkspace to get the frontmost application, using the frontmostApplication method:
let workspace = NSWorkspace.shared
let frontmostApp = workspace.frontmostApplicationUse AXUIElementCreateApplication to create an AXUIElement for the frontmost application, using the processIdentifier of the NSRunningApplication object from step 1:
let pid = frontmostApp?.processIdentifier
let app = AXUIElementCreateApplication(pid!)Use AXUIElementCopyAttributeValue to get the main window of the frontmost application, using the kAXMainWindowAttribute constant and the AXUIElement object from step 2:
var mainWindow: AXUIElement? = nil
let error = AXUIElementCopyAttributeValue(app, kAXMainWindowAttribute as CFString, &mainWindow)Use AXUIElementSetAttributeValue to restore focus to the main window of the frontmost application, using the kAXMainWindowAttribute constant and the AXUIElement object for the main window from step 3:
let error = AXUIElementSetAttributeValue(app, kAXMainWindowAttribute as CFString, mainWindow)Release the AXUIElement objects when you are finished with them, using the CFRelease function:
mainWindow?.release()
app.release()Note that these steps are provided for informational purposes only, and may not work as expected in all situations. You may need to modify the code to handle errors and other edge cases. For more information, you can refer to the documentation for the NSWorkspace, AXUIElementCreateApplication, AXUIElementCopyAttributeValue, and AXUIElementSetAttributeValue functions.
Hey @karlhorky, sorry have abandoned this project for a while. Thanks for looking at how to solve this problem 🙏 I'll try take a look at this (and some other issues) over the coming weeks.
No problem, can totally understand getting busy!
Thanks for taking a look soon! 🙌
I tried to implement this myself in XCode, but I couldn't get the project to build - even after pod install, it could not find the RxSwift module (kind of like this problem):
No such module 'RxSwift'
I'm pretty new to XCode development so I didn't quickly find a workable solution on this, but if you have tips for setting up a project on my machine (MacBook Pro M1, macOS Ventura 13.0.1 (22A400), XCode 14.1 (14B47b)), I'd be glad to give them a try!
Ah classic - have run into those kinds of problems before. Always problems when you update Xcode... I've got an M1 now so will see how I go; will likely have to update some configuration, then hopefully will work for the both of us 🤞
Hey @mattDavo, hope you're well! 🙌 In case you get any time to set up Yippy with new XCode, let me know, I'd be happy to try to move this issue forward a bit more.
The main thing is that I couldn't figure out how to get the project to build - tried debugging a bit but didn't find a solution back then
Hey @karlhorky, I'm doing well I hope you are as well!
Wow a year has gone by quick 😅 I did actually try to get it up and running back then but just couldn't figure it out either... I meant to keep trying but well...
I've just had another attempt with some more success than last time 🎉 I've pushed some changes in matt-revamp-dev-env which gets it working for me.
If you checkout and run pod update in the project root directory hopefully it will work for you 🤞