matsadler / magnus

Ruby bindings for Rust. Write Ruby extension gems in Rust, or call Ruby from Rust.

Home Page:https://docs.rs/magnus/latest/magnus/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build is broken when trying to use Bytes feature

jwilm opened this issue · comments

Hi, we are trying to use Magnus with the Bytes feature, and it appears 0.6.1 is broken on crates.io

jwilm@cartella  ~/code/magnus  cargo build --features bytes
  Downloaded bytes v1.4.0
  Downloaded 1 crate (58.1 KB) in 0.16s
   Compiling bytes v1.4.0
   Compiling magnus v0.6.1 (/home/jwilm/code/magnus)
error[E0277]: the trait bound `value::Value: From<r_string::RString>` is not satisfied
    --> src/r_string.rs:1747:46
     |
1747 |         handle.str_from_slice(self.as_ref()).into()
     |                                              ^^^^ the trait `From<r_string::RString>` is not implemented for `value::Value`
     |
     = note: required for `r_string::RString` to implement `Into<value::Value>`

jwilm@cartella  ~/code/magnus  rustc -V
rustc 1.72.0 (5680fa18f 2023-08-23)

Sorry about that. Turns out the tests for the bytes feature weren't being run, so I missed something when making changes elsewhere.

Tests should be running now, and I've put out a 0.6.2 release that fixes the error.

Thank you for the bug report.

Thanks for the quick fix!