Deal with GHA deprecation warnings
DMRobertson opened this issue · comments
See matrix-org/synapse#14203 for more context.
The warnings I have in mind are e.g. https://github.com/matrix-org/synapse/actions/runs/4936859583
There are two categories of warnings. First:
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16:
- actions/github-script@v5
That comes from matrix-org/pr-details-action@v1.1. The warning should be fixed by #5, which pulls in matrix-org/pr-details-action#4.
Merging #8 should fix this, which pulls in nwtgck/actions-netlify#847.
Second:
The
set-output
command is deprecated and will be disabled soon.
https://github.com/matrix-org/synapse/actions/runs/4936859583/jobs/8824910967#step:3:30 is probably the easiest way to see where these come from.
- #7 would cover the warnings about bobheadxi/deployments (see bobheadxi/deployments#123 and bobheadxi/deployments#124)
- the rest should be covered by #8.
I am happy to do this.
I am happy to do this.
I was going to PR the changes, but I think merging #5, #7, #8 should fix this. @t3chguy would it be possible to merge those and release a new version of this action? (If it's any easier, I'm happy to do so if you prefer and are willing to grant me write access to the repository.)
Thank you!!