matrix-org / matrix-authentication-service

OAuth2.0 + OpenID Provider for Matrix Homeservers

Home Page:https://matrix-org.github.io/matrix-authentication-service/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`http.public_base` is not behaving as expected without a trailing slash, leading to confusing errors

sandhose opened this issue · comments

If one sets the public_base to something like https://domain/account, MAS will still construct URLs with https://domain/ as the base.

This is because of the behaviour of Url::join, which is sensitive to trailing slashes on the base URL. We should either add the trailing slash (and issue a warning) if it's missing, or even refuse to start