LookupWellKnown doesn't specify user agent
phol opened this issue · comments
Background information
- Dendrite version or git SHA: v0.3.5
- Monolith or Polylith?: Monolith
- SQLite3 or Postgres?: postgres
- Running in Docker?: no
go version: go1.15.2 linux/amd64
Description
Right now, Dendrite identifies itself with the User-Agent string Go-http-client/2.0. This should be something like Dendrite/0.3.5, just as Synapse does.
Steps to reproduce
- Tail your web server access logs for
/.well-known/matrix/server - Dendrite identifies itself as
Go-http-client/2.0 - Synapse identifies itself as
Synapse/1.24.0
Note that this only applies to .well-known requests, not federation requests in general.
I was going to say, I thought we did as per https://github.com/matrix-org/dendrite/blob/v0.3.8/setup/base.go#L313
Well-known requests are exempt from that because LookupWellKnown in gmsl doesn't use the Client or FederationClient from setup.
Moving this issue to the gmsl repo.