matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!

Home Page:https://matomo.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] Unused methods in `chai-extras.js` related to UI tests

michalkleiner opened this issue · comments

What happened?

checkForDangerousLinks and performAutomaticPageChecks in chai-extras.js are not used since switching from PhantomJS to headless Chrome 5 years ago.

What should happen?

The methods should be reinstated or removed.

How can this be reproduced?

Look at the code at https://github.com/matomo-org/matomo/blob/5.x-dev/tests/lib/screenshot-testing/support/chai-extras.js#L259 and search for usage of the mentioned methods.

Matomo version

5

PHP version

N/A

Server operating system

N/A

What browsers are you seeing the problem on?

Not applicable (e.g. an API call etc.)

Computer operating system

N/A

Relevant log output

No response

Validations