Formatting of code in the report

Question

Formatting of code in the report

cznic opened this issue 12 years ago · comments

Hi,

like this tool! Ad title: The source code in the report has sometimes malformed indentation (off by one level in both ways: 1 too much or 1 too les). It's only cosmetic, the tool is usable anyway. Thanks for publishing it.

Mathias M. · Answer 1 · Tue Jan 22 2013 22:14:04 GMT+0800 (China Standard Time)

Yes, I noticed that issue. Can't work on it for now but I'm accepting patches :) Thanks for your feedback!

cznic · Answer 2 · Wed Jan 23 2013 20:07:30 GMT+0800 (China Standard Time)

Verified the fix, it works AFAICS, thus closing the issue (leaving the N spaces TODO up to you). Thanks for accepting the patch. The tool is now perfect in every aspect I have for the time being. (Will delete my fork, no reason for it to exist anymore.)

Mathias M. · Answer 3 · Wed Jan 23 2013 20:36:25 GMT+0800 (China Standard Time)

Fine. I'll try to address this indent bug ASAP.

cznic · Answer 4 · Wed Jan 23 2013 20:41:54 GMT+0800 (China Standard Time)

I'm confused. The bug in indentation of the code shown in the report is already fixed by replacing \t by N spaces as seen here:

https://github.com/matm/gocov-html/blob/master/cov/annotate.go#L109

I verified it works from a fresh clone of your repo and making a fresh binary of the tool and it works okay. That's why I closed this issue.

cznic · Answer 5 · Sun Jan 27 2013 20:03:40 GMT+0800 (China Standard Time)

Commit 1319ef2 made it broken again.

In annotate.go:

s/strings.Replace(line, "\t", "        ", 1)/strings.Replace(line, "\t", "        ", -1)/

Mathias M. · Answer 6 · Sun Jan 27 2013 21:13:07 GMT+0800 (China Standard Time)

Fixed. Thanks for reporting, that was a typo...