matklad / xshell

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`ignore_status` should take a boolean argument

matklad opened this issue · comments

We should spell it as .ignore_status(true), to match .echo_cmd() and in general to be a friendlier API. Sadly, that would be a breaking change.

We do have set_ignore_status:

xshell/src/lib.rs

Lines 877 to 880 in 11ab785

/// Controls whether non-zero exit status is considered an error.
pub fn set_ignore_status(&mut self, yes: bool) {
self.data.ignore_status = yes;
}