Why does `applyMiddleware` mutate the schema passed into it?

Question

Why does `applyMiddleware` mutate the schema passed into it?

lastmjs opened this issue 4 years ago · comments

Hi there,

Thanks for all of the hard work on this library.

I just battled a bug for a while, it was very confusing trying to figure out what was happening. The answer it seems is that applyMiddleware is actually mutating the schema passed into it. I was under the assumption that the API was immutable, considering the modified schema is returned from applyMiddleware. This assumption led me to believe that I could reuse the schema passed in without the middleware applied. This caused big problems.

It would be nice if applyMiddleware could be immutable as the API implies. Is there a reason for it to not be immutable?

If mutations are necessary for some reason, could this be documented somewhere?

Thanks!

Luiz Victor Linhares Rocha · Answer 1 · Fri Dec 04 2020 21:21:10 GMT+0800 (China Standard Time)

duplicate of #63

Matic Zavadlal · Answer 2 · Sat Dec 19 2020 00:42:42 GMT+0800 (China Standard Time)

This has been resolved now.