delete arguments.callee
masx200 opened this issue · comments
delete arguments.callee
We appreciate your interest in trying to improve MathJax by submitting these PRs. The code you are modifying is some of the earliest written for MathJax back in 2008, and is foundational for the object-oriented programming model used in v2 and below. It was quite delicate at the time, and the handling of SUPER was one of the more fragile parts of the code, with some complications involving subclasses and updating methods that I'm not sure are addressed in these PRs.
You have not really provided much in the way of explanation for what you are doing, or how you have tested that this does the same thing as the original code. In addition, some of the PRs seem to make the same changes to the same files. All three PRs should be combined into a single PR that makes the changes clear and explains them. Also, we follow the fit-flow model here, so changes should be on a branch that originates from the develop branch and targets the develop branch, not the master branch. You would have to rebase you changes off develop for them to be considered.
In any case, because this is legacy code in v3, we are not anxious to make adjustments to these files, especially in such a fundamental area of the legacy code. What really needs to happen is that the AsciiMath input jax needs to be ported to a true v3 input jax so that the legacy code can be dropped. If you are interested in such a project, a PR that does that would be welcome. For now, I am going to close these PRs.
I've created a repository, have solved the arguments.callee issue, and have used rollup to package it, and the tests passed successfully! Cheers!
https://github.com/masx200/mathjax-module-async/tree/1.6.0
https://github.com/masx200/MathJax-src/tree/3.2.2-delete-arguments.callee
https://github.com/masx200/MathJax/tree/3.2.2-delete-arguments.callee