Giters

mathieucarbou / license-maven-plugin

Manage license headers in your source files

Home Page:https://oss.carbou.me/license-maven-plugin/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

License enforcement fails on 4.2.rc3

michael-simons opened this issue · comments

commented

Version affected

4.2.rc3

Describe the bug

If I add dependency enforcement to 4.2.rc3 the build fails with

 Execution validate of goal com.mycila:license-maven-plugin:4.2.rc3:check failed: Cannot invoke "org.apache.maven.project.MavenProject.getArtifact()" because "project" is null

How to Reproduce

Please be so kind and clone https://github.com/michael-simons/neo4j-migrations

  • Run ./mvnw license:check
  • Notice it works
  • Run ./mvnw -Dlicense-maven-plugin.version=4.2.rc3 license:check

above exception is thrown.

Here's my config https://github.com/michael-simons/neo4j-migrations/blob/4ee8e0315f51b0a7152afa23665331fa47f79e68/pom.xml#L553-L639

Thank you.

commented

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

commented

Nothing has changed. I’d love to have some feedback. Thanks.

commented

Looks like a potential regression with this commit:
be2dfa2

Seems buildingRequest isn't in scope and is pulling from the class. Based on other lines in this file there's some cross-reference between project and buildingRequest but I'll defer to @hazendaz here to try to explain it.

commented

will take a look in a few days.

commented

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

commented

Please keep it open.

commented

haven't forgotten about this, just haven't had time. The code was changed because maven changed the method signature. Will need to dig more into this specific issue but did want to at least comment on why it changed on be2dfa2

commented

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

commented

Keep it open please.

commented

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

commented

Thanks for re-opening this.

Can I maybe help solving this?

commented

The problem is in this commit. If you can read @hazendaz mind to figure out what he meant, please do!

commented

I forked the project and the first thing I noted, that the *IT tests do not run at all… :( So MavenProjectLicensesIT does not do anything.

commented

The original change I did was only to use newer dependency tree as its method signature changed.

    DependencyNode buildDependencyGraph( ProjectBuildingRequest buildingRequest, ArtifactFilter filter )
        throws DependencyGraphBuilderException;

@michael-simons Thanks for PR to try to remediate the issue. I've approved it to run and reviewing it now...