matheusgadelha / PrGAN

Code for Unsupervised 3D Shape Induction from 2D Views of Multiple Objects (3DV 2017)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Projection Module Array Out of Bounds

qiaogh97 opened this issue · comments

Hello! @matheusgadelha
My question is about the projection module, I find in the code ops.py line136 - line138. Your code limits xs, ys, zx between 0 and 64, should it be 63? Because the number is 64, but the coordinate is between 0-63.
In line 86 the same file, you clip the value between 0 and 64. So in line 65 , this code tf.gather(flat_params, flat_indices, name=name) will have a out of bound problem. Fortunately, Tensorflow will put the value whose coordinate is out of bounds to 0 in GPU. But I want to achieve this code using Pytorch.
Therefore, I want to know why is 64 instead of 63? Is it a bug or 64 will have a perfer effect?