mateusz-bak / openreads

A mobile books tracker written in Flutter that respects your privacy.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Incorrect date formatting from locale

james-n-sanders opened this issue · comments

Describe the bug
Dates are displayed as MM/DD/YYYY in Australia, when PR #376 suggests it should be formatted according to device locale.

To Reproduce
Steps to reproduce the behaviour:
Use version described below in Australia.

Expected behavior
The usual date format in Australia is DD/MM/YYYY, so I would expect that to be the case in app when the device is in Australia. As far as I remember this used to be the case in Openreads (not sure when it changed, maybe in 2.X?). I'm not entirely sure how to check the device locale that would be used here, but it is an Australian-bought phone that has only ever been used in Aus (and briefly NZ), with Google play set to Australian marketplace and all time and date settings to use locale (see screenshots). Maybe a manual override for date format could be possible if this is non-trivial to fix?

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot_20240125-002221

Additional info(please complete the following information):

  • App version: 2.3.0
  • App source (F-Droid, Google Play, Github, AppStore): Google Play
  • Manufacturer and model: Google Pixel 7a
  • OS and version: Android 14

Additional context
Add any other context about the problem here.

I corrected how dates are formatted from the locale. Implementing changing only date's locale in settings might be challenging, so please after new version is released check if it's working and report back (re-open if needed). Cheers!