Remove defined1/2.cpp
Flamefire opened this issue · comments
What is the purpose of the empty files defined1/2.cpp and defined.hpp?
They get compiled for each test (there are >100 tests) and slow down the test/build considerably
Remove them?
Similar for undefined: It is only used in 1 test but needlessly compiled for all. Only compile for that 1 test?
If you look at the history for these files I believe it explains what they intend to test:
- defined.hpp: 86371b5#diff-4c70002b08ea2c82a0da9f4652b43c4d
- undefined.hpp: c697b48#diff-654c393c98f706d42ec3171d329e5f8d
I would be a bit reluctant to just remove them as they’re safeguards against possible regressions.
Ah ok. Then how about creating a test that consists of defined1/2.cpp and only links them together (tests the "multiple inclusion issue") and adding the undefined.cpp only to the 2 tests using it? This would avoid the 300 needless compilations... With MSVC this takes a lot of time :/