masci / flickr

Go client for Flickr API https://www.flickr.com/services/api/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

flickr.people.getPhotos not unmarshalling list of Photos into slice

focusaurus opened this issue · comments

From what I can tell there's a missing slice in the go struct used to unmarshall ListPhotosResponse. I would expect PhotoList.Photo to have type []Photo but it's just a single Photo struct. I can't get at the individual photo tags that are present in the XML response.

Hey @focusaurus unfortunately I can't look into this, but if you're willing to open a PR with a fix I'll be happy to merge!

OK I was able to adjust the xml unmarshall struct field tags and change the struct shape. With some test parsing code it seems to now be doing what I expect so I should be able to send a PR.

Will open a PR shortly but it's not a backward compatible change so maybe you'll need to bump to v3?