masag0 / DownBeat

Downbeat is a Spotify inspired web application streaming music player-- Ruby on Rails, React, Redux, and PostgreSQL

Home Page:https://downbeat-app.herokuapp.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PA Review: Continuous Play

masag0 opened this issue · comments

  • Audio plays and displays on bottom audio player
  • Users can navigate without audio playback stopping
  • Adequate styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seeds to demonstrate the feature

(Bonus)

  • Users can add songs to a queue that will play
  • Users can adjust the volume, choose to shuffle or repeat, pause, and skip or go back

Great start with the play bar. I can play and pause a song. We noted that the songs were restarting on navigation to another frontend route at the moment, but will be fixed. You noticed that it's because you added withRouter, so the Player Component is restarting whenever props change.

Removed withRouter to fix continuous play and added play icons next to song titles. Also updated the audio player to display song info and links to appropriate pages.

Awesome! The songs continuously play as I navigate to various parts of the app. This MVP is complete. Bonus features would include adding entire playlists/albums to the queue. Additionally, having a slider on the song would be cool.