Giters

masag0 / DownBeat

Downbeat is a Spotify inspired web application streaming music player-- Ruby on Rails, React, Redux, and PostgreSQL

Home Page:https://downbeat-app.herokuapp.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PA Review: Song/Playlist CRUD

masag0 opened this issue · comments

commented
  • Seed database with appropriate data
  • Allow user to see all of their playlists
  • Allow user to add and remove songs from playlists
  • Allow user to edit their playlists
  • Adequate styling
  • Smooth, bug free navigation
commented

Awesome work! As far as functionality, all works. I can read, create, edit, and delete a playlist, as well as add and delete songs.

A few minor styling suggestions before we close this MVP:

  • The modal that pops up when you create a playlist doesn't scroll on small screens, making the button unreachable.
  • Create Playlist button is not centered.
  • the label .category-detail-label should go into the session-detail-text container.
  • Profile Dropdown is unnecessary, can just be name. It doesn't need to link to anything, could just be browse.
  • Decide whether you want a Playlist index page like Artists/Albums. If not, you can remove the link ui.
  • "Songs" could be removed until you implement My Library in the bonus feature.
  • The song list in the playlist show doesn't need the # column (unlike Albums). You can replace it with a play button on hover.
  • Remove the
    tags from the left nav section, and wrap the two menus in classes so you can style the spacing.
  • Remove unnecessary scrolling from pages so it feels more full of content.

Bonus:

  • Be able to click a button to add an entire album to a playlist.
commented

Completed all requested feedback

commented

Fantastic, it looks so good. This MVP is complete.