Giters

masag0 / DownBeat

Downbeat is a Spotify inspired web application streaming music player-- Ruby on Rails, React, Redux, and PostgreSQL

Home Page:https://downbeat-app.herokuapp.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PA Review: User Authentication

masag0 opened this issue · comments

commented
  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Components, containers and presentational
  • Styling
  • Smooth, Bug Free Navigation
  • Adequate and Appropriate Seeds
commented

Looks awesome! During our meeting today we figured out a bug with Auth and Protected routes. Previously, when logged in, refreshing always redirected to the home page, and now it stays on the same one.

A few small styling comments:

  • The Downbeat h2 element could have a bolder font weight
  • Lines on separator-container are not centered vertically.
  • Increase padding to 100px on the forms, and maybe up opacity to .90.
  • Make errors red for visibility.

Additionally:

  • Clear errors when switching forms.

Later on, if you wanted to refactor the login/signup as a react-modal, that could be a nice bonus.

commented

Completed addressing feedback

commented

Awesome, looks great! This feature is complete.

Optional comment:

  • Allow the login/signup form to submit from a user hitting the enter key instead of click. Makes for an easier experience.
commented

Refactored code to onSubmit handler on the form