maruohon / justenoughdimensions

A simple Minecraft mod to register custom dimensions to the game

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Compatibility] Lost city Biospheres spawn and Just Enough Dimensions

mr-poyo opened this issue · comments

When i have Just Enough Dimensions installed, i am unable to force the spawn inside sphere via the lost city profile config option . If i disable just enough dimensions, it works fine.

Was hoping this could be fixed as i would love to get the best of both worlds. Thank you!

Does Lost Cities normally handle the spawn point, I assume so? You should be able to disable JED's spawn point search/override like in this example config: https://pastebin.com/2dJNFfcR (the SpawnPointSearchType bit). This only works in some of the latest 1.6.0 beta versions.

Edit: Actually, is this dimension registered by JED or do you do some edits to it via JED? Otherwise JED shouldn't affect a totally non-JED dimension... not sure if that's what you meant.

Hello,

I am using lost cities bop as my overworld, and currently have no entries in dimensions.json (for testing).

In the lost cities' biosphere profile config, you can specify spawn to be inside a sphere using "in", it stops working when i have JED enabled, even with a lot of the JED config options set to false. I have not yet tried registering the overworld with an override with the spawn config option you posted, I'll be able to test it tonight after work.

Oh, well that is very strange then indeed... JED isn't supposed to affect anything for a dimension if you don't have anything configured for that dimension. I'll need to try it out and try to figure out what's going on then. Can you post the Lost Cities configs and stuff you are using, so I can try to reproduce it with the same configs?

Unfortunately, I was not able to get the SpawnPointSearchType working.
For troubleshooting & demonstration, I went ahead and created a new modpack project to test the issue, and it still exists.

Mods Used:
image

All config options were left default with the exception of \config\lostcities\profile_biosphere.cfg

profile_biosphere.cfg (https://pastebin.com/mzS0grAR) has been edited to match the concept I'm hoping to achieve.
Line 379 Change: S:spawnBiome=
Line 388 Change: S:spawnSphere=

If I disable Just Enough Dimensions, it works fine (spawn in sphere) as outlined below:
image
image
image

If I enable Just Enough Dimensions, I spawn outside of sphere (outlined below):

image
image

I just uploaded a new build to CurseForge, which rewrites some of how the spawn point search stuff in JED works. Basically it doesn't forcibly search for an overworld spawn point anymore, fixing this issue.

Verified that it is working. Thank you for your fast action on this!! :D