martinus / map_benchmark

Comprehensive benchmarks of C++ maps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

boost::hash removed

joaquintides opened this issue · comments

Hi, 1a6323c removes boost::hash because, allegedly, "it's exactly the same as std::hash". But I don't think is is the case at all, unless I'm missing something in context.

Thank you!

For uint64_t input it produces exactly the same results as std::hash, just the identity. But you are right, its probably different for strings. Or am I missing something else?

Yes, for integrals boost::hash is just the identity. But it is different to std::hash for strings, which are also tested in your benchmarks.

I'll add it back

Thank you!

I'll keep it open until I actually add it back so I don't forget 🙂