SMTP backend not raising SMTPRecipientsRefused
hyperknot opened this issue · comments
I am trying to send a message with wrong configured sender. I am getting the following line in the log:
2017-02-15 03:28:25,154 WARNI [marrow.mailer.transport.smtp] <148712570228.24873.12356218486855342422@....local> REFUSED SMTPRecipientsRefused {u'...@gmail.com': (550, '5.1.0 <noreply@....com>: Sender address rejected: User unknown in relay recipient table')}
My problem is that nothing else happens. That exception is not raised, just silently logged.
I believe an exception like this should be treated similarly to if a sending couldn't happen for example because of wrong password or something. That one raises an exception, this one does not.
The reason is this line is just silently "eating" all exceptions:
mailer/marrow/mailer/transport/smtp.py
Line 105 in 3995ef9
It's not "eating" exceptions, it's transforming them.
mailer/marrow/mailer/transport/smtp.py
Lines 125 to 129 in 3995ef9
Admittedly, this folds SMTPSenderRefused
and SMTPRecipientsRefused
into a single MessageFailedException
whose args[0]
references the actual exception that occurred. Additionally, it logs a message that should contain sufficient information to identify which recipients were rejected.
This clearly requires an explicit test case.