marmelab / ng-admin

Add an AngularJS admin GUI to any RESTful API

Home Page:http://ng-admin-book.marmelab.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Filter value is not updated based on search url parameter

tpaan opened this issue · comments

Description

If you are on a view with filters and you click on a link that changes the search url parameter value then the view is filtered correctly based on the new search value, but the displayed filter value is not updated.

This used to work correctly in v1.0.0-beta3 and is broken since version 1.0. I believe this commit is at fault: 4fc19b1

Steps to Reproduce

  1. Open this Plunkr demo: http://plnkr.co/edit/1SQO4nqnwuG0FTCZTFwl?p=preview
  2. Click on menu link "Users with filter 'John'"
  3. Change name filter to Cathy
  4. Click on menu link "Users with filter 'John'" again

Expected behavior: Name filter should show correct value John

Actual behavior: Name filter stays as Cathy

Gif demo:
filters

commented

I noticed this also and am not entirely sure what the behaviour should be.
If a user changed the default filter then navigate away and come back. Shall it retain the value he entered or the default one that was set ?

That odd behavior can also be seen on the ng admin demo

@djhi whats your input on those use cases ?

Should be solved by #1333

It should now be fixed. We'll publish a release soon!