markusfisch / BinaryEye

Hi Markus 👋🏻 I like your scanner because it shows the raw QR data without data type prefixes or end padding. It helps me to debug custom QRs, but I really miss the ability to copy HEX data.

Currently, if the QR content can't be decoded as text, there are no "Copy" and "Share" buttons on the decoded code, and you have to write it as a file:

However, in the code there is the ability to copy HEX instead of text if the code is binary:

BinaryEye/app/src/main/kotlin/de/markusfisch/android/binaryeye/fragment/DecodeFragment.kt

Lines 321 to 324 in e99e2d7

    
           R.id.copy_to_clipboard -> { 
        
           	copyToClipboard(textOrHex()) 
        
           	maybeBackOrFinish() 
        
           	true

But the "Copy" button gets hidden when the code is binary:

BinaryEye/app/src/main/kotlin/de/markusfisch/android/binaryeye/fragment/DecodeFragment.kt

Lines 302 to 305 in e99e2d7

    
           if (isBinary) { 
        
           	menu.findItem(R.id.copy_to_clipboard).isVisible = false 
        
           	menu.findItem(R.id.create).isVisible = false 
        
           }

Is this a bug or feature? If the buttons are actually meant to be available for binary content, I'll submit a PR with the fix.

Hi Radiokot, this is a bug actually! Good catch!

Line 303 is a remnant from before there was textOrHex() and should be removed. So, if you like to do a PR please go ahead! Otherwise I would fix it, if you wouldn't mind.

Many thanks for clarifying, will submit the fix soon.

	R.id.copy_to_clipboard -> {
	copyToClipboard(textOrHex())
	maybeBackOrFinish()
	true

	if (isBinary) {
	menu.findItem(R.id.copy_to_clipboard).isVisible = false
	menu.findItem(R.id.create).isVisible = false
	}

Can't copy data of a binary QR