--color=auto should detect if output supports colors

Question

markus-wa opened this issue 2 years ago · comments

pretty was released with automatic logic for enabling colors. Seems pretty straightforward: clj-commons/pretty@7cb0c16

Markku Rontu · Answer 1 · Fri Oct 28 2022 22:59:27 GMT+0800 (China Standard Time)

So should we only check for existence of System.console() or the REPL trick too?

 (or (contains? (set (loaded-libs)) 'nrepl.core)
     (System/console))

I guess we don't need the env var check?

Markus · Answer 2 · Fri Oct 28 2022 23:13:53 GMT+0800 (China Standard Time)

the above looks good. REPL trick is probably a good idea but env var not needed IMO (it's not a standard env var)

Markku Rontu · Answer 3 · Fri Oct 28 2022 23:21:40 GMT+0800 (China Standard Time)

Yeah, that's what I thought. I'll make a PR sometime 👍

Markku Rontu · Answer 4 · Mon Oct 31 2022 17:51:04 GMT+0800 (China Standard Time)

Here's the PR #20

Markus · Answer 5 · Mon Oct 31 2022 22:21:06 GMT+0800 (China Standard Time)

amazing, thanks - will make a new release shortly 🙂