marksteve / cards

Online multiplayer card games

Home Page:https://dos.marksteve.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[bug] Invalid card combination is allowed in the game

ardieorden opened this issue · comments

Hi @ardieorden, can you be more clear with your issue? That card combination is not allowed in traditional pusoy dos rules.

By any chance, do you mean that the app currently allows this combination?

Thanks for the report!

Hi @ardieorden, can you be more clear with your issue? That card combination is not allowed in traditional pusoy dos rules.

By any chance, do you mean that the app currently allows this combination?

Thanks for the report!

Hi @ajatamayo , I'll update my comment now.

When can we expect a fix @marksteve ....

Thank you for the report. Expect an update within this year.

Hello, this happened a few times for us as well unfortunately!
Screen Shot 2021-03-17 at 6 18 58 PM

This other one is similar to the previously reported bug.
Screen Shot 2021-03-17 at 6 30 27 PM

@marksteve would you like some help from someone who is on leave

@syk0saje gopher it!

fix is ready, just need write access. the problem was a || that should have been && for full house detection. that means if your first 2 cards were a pair or if the last 3 cards were a trio, it would register as a full house. this covers all 3 samples above. regression tests were also added for each instance.