[proposal] migrate to golangci-lint

[Chase Pierce]

I'm happy to do this work, but thought I'd open it as an issue first to see if you're even interested in the change. I propose a swap over to golangci-lint over gometalinter.

The two main reasons for this change are:

• It's substantially better performing, works better in a Go 1.11 ecosystem (although they're still working with some linters to get them up to snuff, so it's a work in progress)
• Can be installed via shell, which improves usage and start time in CI and Docker

I could list more reasons, but at that point it's just getting to my personal thoughts on one tool over another.

Would you be open to me swapping the tools out? For the first

[Mark Bates]

Let me get back to you on that. I haven’t used that linter yet, so I want to play around with it a bit first, if that’s OK?

…

----------- Mark Bates

On Feb 3, 2019, 5:18 PM -0500, Chase Hutchins ***@***.***>, wrote: I'm happy to do this work, but thought I'd open it as an issue first to see if you're even interested in the change. I propose a swap over to golangci-lint over gometalinter. The two main reasons for this change are: • It's substantially better performing, works better in a Go 1.11 ecosystem (although they're still working with some linters to get them up to snuff, so it's a work in progress) • Can be installed via shell, which improves usage and start time in CI and Docker I could list more reasons, but at that point it's just getting to my personal thoughts on one tool over another. Would you be open to me swapping the tools out? For the first — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Chase Pierce]

Totally, it's no rush. Are you in the Golang Slack btw? Wanted to have a quick chat.

[Talha Altınel]

golangci-lint is really great, it really helps a little by helping with rookie mistakes and neat suggestions, downside is that you need to have a really good .golangci.yaml with lots of configs and eventually lock yourself to a specific linter version