Giters

marius311 / CMBLensing.jl

The automatically differentiable and GPU-compatible toolkit for CMB analysis.

Home Page:https://cosmicmar.com/CMBLensing.jl

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support non-square flat-sky maps

marius311 opened this issue · comments

commented

I think the right (and also easiest) path is to have the Nside parameter in abstract type Flat{Nside,θpix,∂mode<:∂modes,D} <: Pix end just be a tuple of (Nx,Ny). This doesn't require changing any types. Then its just:

  • Update FFT planning to reflect rectangular maps
  • Have fieldinfo also return Nx and Ny keys which it unpacks out of Nside for you.
  • Search the code for references of Nside and make sure it makes sense.

One thing to decide is whether to still allow scalar Nside, which would imply a square map. This would make this change backwards compatible.

commented

Above PR merged in 0.4.0.