mariohahn / MHVideoPhotoGallery

A Photo and Video Gallery

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Thumbnail youtube video

dpizzuto opened this issue · comments

When I load the photogallery with correct youtube item, the thumbnails inside gallery have grey image and length of 00:00 sec. Vimeo's video haven't this issue.
Is it a known issue ?

maybe its because the youtube v2 is deprecated. #95

I saw that actually there isn't a workaraound for fix this issue, right ?

as far as i know not yet

I saw one implementing V3. But i can't find it now :(

I'll try to find out the new v3 api. I'll let you know. Please, keep this issue opened.

I found a solution: I had to integrate new v3 api with api key and new URLs. For now, I adapted the code for my goals that are thumbnail and video duration. As soon as possibile, I'll fork your project and push the new code with pull request. Keep issue opened until I finish the operations.

👍 This PR fixed the same issue that I was having. Hopefully something with this gets pulled into the master repo.

Although it does seem a little funny to have to edit one of the Pod files (MHGallery.m) to add your API key. Is it possible to load this value from plist value instead?

I don't like both of this ways... Maybe something have like this a just a Property:

extern void MHGalleryCustomLocalizationBlock(NSString *(^customLocalizationBlock)(NSString *stringToLocalize));

Yes Chris, isn't the best solution so far but was, as described, a quick & dirty solution for my purpose. A good way, in my opinion, maybe to have a property to set in a SharedObject.

property would be the best (:

I went ahead and took a stab at this using MHGalleryCustomLocalizationBlock.

Guys, does app support all possible youtube urls for downloading thumbnails and playing video? I found an issue with urls:
"http://youtu.be/Jmb7NgNouoM"
or
"https://www.youtube.com/embed/DheulkmtR7Y?vq=hd720&rel=0&showinfo=0&modestbranding=1&enablejsapi=1&origin=http%3A%2F%2Fwww.shyp.com"

BTW the same issue with Vimeo for link:
"https://player.vimeo.com/video/99743076?api=1"