mariocasciaro / gulp-clone

Clone files in memory in a gulp stream

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Version 1.1 breaks for larger builds

specimen151 opened this issue · comments

FYI:
After the new version came 7-8 days ago, Semantic-UI won't build any more. Of course that is an issue for that project, but I'm letting you know in case there is some underlying issue with the new version of gulp-clone. From what I've seen it it seems the size have something to do with it (if I build a larger stream/clone... don't know the term... then it crashes).

Noticed that some underlying dependencies have changed, and maybe there are some limitations on them.

Semantic-Org/Semantic-UI#6067

Is this closed as fixed, or unable to reproduce, or out of scope? Thanks

I could not find the delete button, so I closed it. Could be the other project is using gulp-clone wrong, I really don't know, so I changed my mind and wanted to delete the issue from gulp-clone. It has been working (and still is) with 1.0.0 though.

👋 Hello! Semantic-Org/Semantic-UI#6067 is still on-going, could this ticket be reopened or should I make another one? Appears to have been caused by 918beb6 so likely some difference between gulp-util/vinyl and their replacements.

@mariocasciaro Would you accept a PR to revert that change temporarily to release a 1.1.2 to fix things, then release the change with a 2.0.0 instead? That would be super helpful to resolve for folks, if you're cool with it? 😄


semantic-ui users can workaround it by including 1.0.0 in your own package.json to prevent semantic-ui from picking up the newer version.

rm -rf node_modules
npm install gulp-clone@1.0.0 --save-exact
npm install

Done.
1.1.2 now contains the 1.0.0 code.
2.0.0 now contains the new version which drops the dependency on gutils.

@mariocasciaro thank you! 🍻