marian-craciunescu / ESP32Ping

Ping library for ESP32 Arduino core

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

comment unused functions

adynis opened this issue · comments

in ping.cpp there are 3 functions which are unused:
ping(...)
ping_regist_recv(...)
ping_regist_sent(...)
The unused function ping(...) is slightly different because it does not depend on the options set, and it can not trigger the callback function registered initially.

My proposal: just comment them out !

PS. this helps also issue #6

After aligning with Owner, all functions will be kept.
Closing this one.