Issues with add link URL control

Question

Issues with add link URL control

liadbe opened this issue 5 years ago · comments

liadbe commented 5 years ago

Hi, 2 issues we encountered with the add link control:

It is not possible to copy text from the input of the url (neither ctrl+c or _right-click).
If URL prefix (https://) is not entered, it automatically adds the domain name before the URL entered in the link . We solved it using the link hook.

Thanks,
Liad

超能刚哥 · Answer 1 · Fri May 10 2019 16:30:00 GMT+0800 (China Standard Time)

Confirmed, I will fix the first issue soon.

liadbe · Answer 2 · Wed Jun 19 2019 21:39:30 GMT+0800 (China Standard Time)

Hi,
Regarding the 1st issue, now when I try to copy the URL (e.g. https://google.com), it copies the text of the URL instead (e.g. visit Google).
Worth mentioning I am not using allowInsertLinkText (by default it's false).

超能刚哥 · Answer 3 · Wed Jun 19 2019 22:04:07 GMT+0800 (China Standard Time)

@liadbe I will take a look tomorrow. I just noticed that this problem does not exist in react-draft-wysiwyg, so it should be repairable.

超能刚哥 · Answer 4 · Thu Jun 20 2019 21:34:27 GMT+0800 (China Standard Time)

Hi, I just published v2.3.7 and this issue should be fixed :)

liadbe · Answer 5 · Mon Jul 22 2019 19:57:59 GMT+0800 (China Standard Time)

Hi, I thought this issue is behind us. But something weird is happenning, these are the steps to reproduce:

Select text inside the editor and click the 'add link' control
Insert url without url prefix (https://), for example - google.com
Select the linked text in the editor
Press right click -> Copy link address
See that the address copied is not just google.com but with added prefix (probably your domain)

Can u please have a look on that?

Thanks.

超能刚哥 · Answer 6 · Mon Jul 22 2019 21:03:40 GMT+0800 (China Standard Time)

The editor won't apply any protocol by default, so you input google.com, for browser, it's just a relative path, you can have a try on any website, find a link and remove the prefix of it by using the browser development tool, then right click the link and copy the url of it.