marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Activity appears with tickable boxes

BMTHMoodle opened this issue · comments

Describe the bug
Activity appears different under different theme. Words are clickable but they have boxes in front of them at the same time. (Screenshot below)

To Reproduce
Steps to reproduce the behavior:

  1. Change theme to Edwiser/Default
  2. Preview activity

Expected behavior
Clickable words, no boxes

Screenshots
image

  • Windows
  • tested on Chrome, Edge
  • Moodle 4.1.8

Tried with different delimiters

I generally only support my plugins under the Themes that ship with Moodle. If it doesn't work with a 3rd party theme I assume there is an issue with the Theme. What you are seeing are the normally hidden checkboxes created for each word in the text. Something in the theme means they are not hidden. The Edwiser people might be able to come up with a straightforward fix.

Is the Edwiser theme freely downloadable anywhere?

Thank you for the quick response, Marcus.
I did anticipate an issue on the theme side as the activity works as intended behind the scenes (in spite of its appearance under the Edwiser theme which is not free).
In any case, I thought you might want to know that the activity might not appear the same under third party themes, which is, understandably, not easy to test. Perhaps someone else on the forum has experience with third party themes causing such issues and suggest a place to start looking.

Thank you for your understanding. Have you confirmed that the core Moodle drag drop things work as expected? They use a different approach for drag and drop. Also can you check the browser console for errors?

Drag and drop text, drag and drop into image and drag and drop markers seem to work fine.

Developer view doesn't show any (breaking) errors, only 4 possible improvements ('A form field element should have a name or id attribute.' > violating node) and a 'mixed content' (https security recommendation).

I think those other messages are fairly "standard". I have investigated issues with popular themes in the past just to check, but a combination of the proprietary nature of Edwiser and thinking it is not massively used means it is not a priority. In retrospect I think there should be an alternative way of handling selection in the way that happens in the mobile app whereby you click to select and then click to drop. Drag drop is in some ways overrated as a method of interaction.

Thank you Marcus. Apologies for the late reply. Just wanted to let you know that we are still investigating this and have taken it up with Edwiser as the problem appears only under their theme. Based on our testing the plugin works as intended behind the scenes, it is just the appearance that breaks when selecting their theme.

Thank you for your feedback, much appreciated.